From c59b36ebf7ac7ecc3c6ba6d43d2e0e575530deb0 Mon Sep 17 00:00:00 2001 From: ghassan Date: Wed, 21 Oct 2026 12:50:48 +0300 Subject: [PATCH] chore(match-css): remove two blocks of dead cascade-overridden CSS MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Two provably-unreachable blocks in resources/views/videos/types/match.blade.php whose cascade targets are overridden further down with !important: 1. The pre-override pair at ~line 320: .events-sidebar { display: none; } .events-sidebar.show { display: flex; } is overridden by the primary .events-sidebar definition further down that sets `display: none !important` and `.show { display: flex !important }`. 2. The first `@media (max-width: 1300px)` block that sized .yt-sidebar-container + .events-sidebar to 300 px is overridden by the SECOND `@media (max-width: 1300px)` block immediately after, which sets both to `width: 100% !important` as part of the stacking layout. Same breakpoint, same selectors, !important wins. Both removals leave Blade comments in place so the next reader can see why the gap is there. Smoke-tested: /, /videos still 200; full test suite 80/80 green. Full consolidation of the four responsive .events-sidebar variants (desktop, 1300 px stacking, 991 px bottom sheet, fullscreen drawer) is left for a future turn with a browser visual-regression harness — each variant has a distinct behavior that would be risky to merge without one. Co-Authored-By: Claude Opus 4.7 (1M context) --- resources/views/videos/types/match.blade.php | 29 ++++++++------------ 1 file changed, 12 insertions(+), 17 deletions(-) diff --git a/resources/views/videos/types/match.blade.php b/resources/views/videos/types/match.blade.php index 2d48a3d..981b57c 100644 --- a/resources/views/videos/types/match.blade.php +++ b/resources/views/videos/types/match.blade.php @@ -317,14 +317,12 @@ /* No rotation animation */ - /* Hide sidebar by default */ - .events-sidebar { - display: none; - } - - .events-sidebar.show { - display: flex; - } + {{-- Dead-code removal (2026-10-21 audit): the previous `.events-sidebar + { display: none }` + `.show { display: flex }` pair here was + overridden further down (search for the `display: none !important` + definition under /* ===== Match Events Sidebar ===== */). The + !important forms silently won every cascade; this pair never + rendered. --}} /* ===== Playlist Navigation Controls ===== */ .playlist-controls { @@ -2009,15 +2007,12 @@ } /* ===== Responsive ===== */ - @media (max-width: 1300px) { - .yt-sidebar-container { - width: 300px; - } - - .events-sidebar { - width: 300px; - } - } + {{-- Dead-code removal (2026-10-21 audit): a prior + @media (max-width: 1300px) block sized .yt-sidebar-container + + .events-sidebar to 300 px. The immediately-following + @media (max-width: 1300px) rule overrides both to 100% with + !important as part of the stacking layout, so the 300 px pair + never applied. --}} /* ── Narrow desktop: too little room for a side rail ────────────── Between 992px and 1300px the left nav (240px) and the 300px rail